hubgeter commented on code in PR #22115:
URL: https://github.com/apache/doris/pull/22115#discussion_r1271713094
##########
be/src/vec/exec/scan/vfile_scanner.cpp:
##########
@@ -245,7 +245,19 @@ Status VFileScanner::_get_block_impl(RuntimeState* state,
Block* block, bool* eo
RETURN_IF_ERROR(_init_src_block(block));
{
SCOPED_TIMER(_get_block_timer);
+
// Read next block.
+
+ if (_parent->push_down_agg_type_opt != TPushAggOp::type ::NONE) {
+ //Prevent FE misjudging the "select count/min/max ..."
statement
+ if (Status::OK() ==
_cur_reader->get_next_block(_src_block_ptr, &read_rows,
Review Comment:
Yes, because `FE` needs to add a lot of redundant code to determine the file
type in order to obtain the correct plan 。
##########
be/src/vec/exec/scan/vfile_scanner.cpp:
##########
@@ -245,7 +245,19 @@ Status VFileScanner::_get_block_impl(RuntimeState* state,
Block* block, bool* eo
RETURN_IF_ERROR(_init_src_block(block));
{
SCOPED_TIMER(_get_block_timer);
+
// Read next block.
+
+ if (_parent->push_down_agg_type_opt != TPushAggOp::type ::NONE) {
+ //Prevent FE misjudging the "select count/min/max ..."
statement
+ if (Status::OK() ==
_cur_reader->get_next_block(_src_block_ptr, &read_rows,
Review Comment:
Yes, because `FE` needs to add a lot of redundant code to determine the file
type in order to obtain the correct plan 。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
