liaoxin01 commented on code in PR #22154:
URL: https://github.com/apache/doris/pull/22154#discussion_r1272347649
##########
be/src/olap/schema_change.cpp:
##########
@@ -429,6 +429,8 @@ Status
BlockChanger::_check_cast_valid(vectorized::ColumnPtr ref_column,
Status LinkedSchemaChange::process(RowsetReaderSharedPtr rowset_reader,
RowsetWriter* rowset_writer,
TabletSharedPtr new_tablet, TabletSharedPtr
base_tablet,
TabletSchemaSPtr base_tablet_schema) {
+ // LinkedSchemaChange is useless, will remove it in the future.
+ DCHECK(false);
Review Comment:
why add this DCHECK？
##########
be/src/olap/schema_change.cpp:
##########
@@ -429,6 +429,8 @@ Status
BlockChanger::_check_cast_valid(vectorized::ColumnPtr ref_column,
Status LinkedSchemaChange::process(RowsetReaderSharedPtr rowset_reader,
RowsetWriter* rowset_writer,
TabletSharedPtr new_tablet, TabletSharedPtr
base_tablet,
TabletSchemaSPtr base_tablet_schema) {
+ // LinkedSchemaChange is useless, will remove it in the future.
+ DCHECK(false);
Review Comment:
why add this DCHECK？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
