HappenLee commented on code in PR #22152:
URL: https://github.com/apache/doris/pull/22152#discussion_r1272665988
##########
be/src/exprs/runtime_filter.cpp:
##########
@@ -1899,8 +1894,20 @@ Status
RuntimePredicateWrapper::get_push_exprs(std::vector<vectorized::VExprSPtr
cloned_expr = prob_expr->root()->clone();
min_pred->add_child(cloned_expr);
min_pred->add_child(min_literal);
- container->push_back(
-
vectorized::VRuntimeFilterWrapper::create_shared(min_pred_node, min_pred));
+
+ TTypeDesc type_desc = create_type_desc(PrimitiveType::TYPE_BOOLEAN);
+ type_desc.__set_is_nullable(false);
+ TExprNode node;
+ node.__set_type(type_desc);
+ node.__set_node_type(TExprNodeType::COMPOUND_PRED);
+ node.__set_opcode(TExprOpcode::COMPOUND_AND);
+ node.__set_is_nullable(min_pred->is_nullable() ||
max_pred->is_nullable());
+
+ auto and_pred = vectorized::VCompoundPred::create_shared(node);
Review Comment:
change to and expr，maybe recheck the expr still can push down to storage
layer？
##########
be/src/exprs/runtime_filter.cpp:
##########
@@ -1899,8 +1894,20 @@ Status
RuntimePredicateWrapper::get_push_exprs(std::vector<vectorized::VExprSPtr
cloned_expr = prob_expr->root()->clone();
min_pred->add_child(cloned_expr);
min_pred->add_child(min_literal);
- container->push_back(
-
vectorized::VRuntimeFilterWrapper::create_shared(min_pred_node, min_pred));
+
+ TTypeDesc type_desc = create_type_desc(PrimitiveType::TYPE_BOOLEAN);
+ type_desc.__set_is_nullable(false);
+ TExprNode node;
+ node.__set_type(type_desc);
+ node.__set_node_type(TExprNodeType::COMPOUND_PRED);
+ node.__set_opcode(TExprOpcode::COMPOUND_AND);
+ node.__set_is_nullable(min_pred->is_nullable() ||
max_pred->is_nullable());
+
+ auto and_pred = vectorized::VCompoundPred::create_shared(node);
Review Comment:
change to and expr，maybe recheck the expr still can push down to storage
layer？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
