morrySnow commented on code in PR #22144:
URL: https://github.com/apache/doris/pull/22144#discussion_r1274326797
##########
fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java:
##########
@@ -1341,9 +1341,13 @@ private void handleQueryStmt() throws Exception {
// Sql and PartitionCache
CacheAnalyzer cacheAnalyzer = new CacheAnalyzer(context, parsedStmt,
planner);
- if (cacheAnalyzer.enableCache() && !isOutfileQuery && queryStmt
instanceof SelectStmt) {
- handleCacheStmt(cacheAnalyzer, channel, (SelectStmt) queryStmt);
- return;
+ if (cacheAnalyzer.enableCache() && !isOutfileQuery
+ && context.getSessionVariable().getSqlSelectLimit() ==
9223372036854775807L
Review Comment:
change the behavior of `getSqlSelectLimit`, if `sqlSelectLimit` < 0 ||
`sqlSelectLimit` >= LONG.MAX_VALUE then return -1;
and then update this if statement to
`context.getSessionVariable().getSqlSelectLimit() < 0`
do same thing to `getDefaultOrderByLimit`
and let sqlSelectLimit and defaultOrderByLimit as private.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
