zhannngchen commented on code in PR #22275:
URL: https://github.com/apache/doris/pull/22275#discussion_r1275822486
##########
be/src/olap/rowset/vertical_beta_rowset_writer.cpp:
##########
@@ -99,19 +99,53 @@ Status VerticalBetaRowsetWriter::add_columns(const
vectorized::Block* block,
uint32_t num_rows_written =
_segment_writers[_cur_writer_idx]->num_rows_written();
VLOG_NOTICE << "num_rows_written: " << num_rows_written
<< ", _cur_writer_idx: " << _cur_writer_idx;
+ uint32_t num_rows_key_group =
_segment_writers[_cur_writer_idx]->row_count();
+ DCHECK(num_rows_key_group > 0);
// init if it's first value column write in current segment
if (_cur_writer_idx == 0 && num_rows_written == 0) {
VLOG_NOTICE << "init first value column segment writer";
RETURN_IF_ERROR(_segment_writers[_cur_writer_idx]->init(col_ids,
is_key));
}
- if (num_rows_written > max_rows_per_segment) {
+ size_t start_offset = 0, limit = num_rows;
Review Comment:
Add more comments here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
