yiguolei commented on code in PR #22152:
URL: https://github.com/apache/doris/pull/22152#discussion_r1275891676
##########
be/src/exprs/runtime_filter.cpp:
##########
@@ -1477,7 +1476,7 @@ void IRuntimeFilter::init_profile(RuntimeProfile*
parent_profile) {
}
DCHECK(parent_profile != nullptr);
_name = fmt::format("RuntimeFilter: (id = {}, type = {})", _filter_id,
- ::doris::to_string(_runtime_filter_type));
Review Comment:
我们应该全局的函数调用，都加namespace 才对，否则区分不清楚是不是对象的函数
##########
be/src/exprs/runtime_filter.cpp:
##########
@@ -1477,7 +1476,7 @@ void IRuntimeFilter::init_profile(RuntimeProfile*
parent_profile) {
}
DCHECK(parent_profile != nullptr);
_name = fmt::format("RuntimeFilter: (id = {}, type = {})", _filter_id,
- ::doris::to_string(_runtime_filter_type));
Review Comment:
我们应该全局的函数调用，都加namespace 才对，否则区分不清楚是不是对象的函数
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
