freemandealer commented on code in PR #22392:
URL: https://github.com/apache/doris/pull/22392#discussion_r1280057580
##########
be/src/olap/rowset/beta_rowset_writer.cpp:
##########
@@ -412,7 +395,6 @@ Status BetaRowsetWriter::_segcompaction_if_necessary() {
}
Status BetaRowsetWriter::_segcompaction_ramaining_if_necessary() {
Review Comment:
Since we are actually not compacting anything, I think the function would
better to be renamed. Otherwise, it would be missleading that there is no more
waiting after 'segcompaction' (see line 608).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
