morningman commented on a change in pull request #4310:
URL: https://github.com/apache/incubator-doris/pull/4310#discussion_r471550193
##########
File path: fe/fe-core/pom.xml
##########
@@ -36,7 +36,7 @@ under the License.
<properties>
<doris.home>${basedir}/../../</doris.home>
- <fe_ut_parallel>${env.FE_UT_PARALLEL}</fe_ut_parallel>
+ <fe_ut_parallel>1</fe_ut_parallel>
Review comment:
Why?
##########
File path:
fe/fe-core/src/main/java/org/apache/doris/analysis/AlterTableStmt.java
##########
@@ -70,6 +76,50 @@ public void analyze(Analyzer analyzer) throws UserException {
}
}
+ public void rewriteAlterClause(OlapTable table) throws UserException {
+ List<AlterClause> clauses = new ArrayList<>();
+ for (AlterClause alterClause : ops) {
+ if (alterClause instanceof EnableFeatureClause
+ && ((EnableFeatureClause) alterClause).getFeature() ==
EnableFeatureClause.Features.BATCH_DELETE) {
+ if (table.getKeysType() != KeysType.UNIQUE_KEYS) {
+ throw new AnalysisException("Batch delete only support in
unique tables.");
+ }
+ // has rollup table
+ if (table.getVisibleIndex().size() > 1) {
+ for (MaterializedIndex idx : table.getVisibleIndex()) {
+ if (idx.getId() == table.getBaseIndexId()) {
Review comment:
miss to modify the base index?
##########
File path:
fe/fe-core/src/main/java/org/apache/doris/analysis/DataDescription.java
##########
@@ -172,6 +183,9 @@ public DataDescription(String tableName,
this.columnMappingList = columnMappingList;
this.whereExpr = whereExpr;
this.srcTableName = srcTableName;
+ this.mergeType = mergeType;
+ this.deleteCondition = deleteCondition
+ ;
Review comment:
code style
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
