liaoxin01 commented on code in PR #22282:
URL: https://github.com/apache/doris/pull/22282#discussion_r1288189905
##########
be/src/olap/tablet.cpp:
##########
@@ -3651,4 +3673,48 @@ Status Tablet::calc_delete_bitmap_between_segments(
return Status::OK();
}
+void Tablet::_add_sentinel_mark_to_delete_bitmap(DeleteBitmapPtr delete_bitmap,
+ const RowsetIdUnorderedSet&
rowsetids) {
+ for (const auto& rowsetid : rowsetids) {
+ delete_bitmap->add({rowsetid, DeleteBitmap::INVALID_SEGMENT_ID, 0},
+ DeleteBitmap::ROWSET_SENTINEL_MARK);
+ }
+}
+
+void Tablet::_remove_sentinel_mark_from_delete_bitmap(DeleteBitmapPtr
delete_bitmap) {
+ for (auto& [key, bitmap] : delete_bitmap->delete_bitmap) {
+ bitmap.remove(DeleteBitmap::ROWSET_SENTINEL_MARK);
Review Comment:
We'd better remove the bitmap of INVALID_SEGMENT_ID from the map.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
