[GitHub] [doris] gavinchou commented on a diff in pull request #20215: [refactor-wip](TaskWorkerPool)add specific classes for tasks

Wed, 09 Aug 2023 21:43:35 -0700 


gavinchou commented on code in PR #20215:
URL: https://github.com/apache/doris/pull/20215#discussion_r1289541177


##########
be/src/agent/task_worker_pool.cpp:
##########
@@ -1963,4 +1745,239 @@ Status 
StorageMediumMigrateTaskPool::_check_migrate_request(const TStorageMedium
     return Status::OK();
 }
 
+CheckConsistencyTaskPool::CheckConsistencyTaskPool(ExecEnv* env, ThreadModel 
thread_model)

Review Comment:
   It's better to reduce duplicated code that declares `XxxTaskPool` multiple 
times by invoking the template.
   Here is an example, the implementation of each callback (template 
specialization) can be put into a separate file
   
![img_v2_668c21f7-9817-43d2-ace1-1516f44843cg](https://github.com/apache/doris/assets/6919662/abc6dfd8-2a3c-4896-b78b-19bc2bb92f8c)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to