EmmyMiao87 opened a new pull request #4408:
URL: https://github.com/apache/incubator-doris/pull/4408


   Define Expr will not serialized in Column `toThrift`.
   
   1. When adding partition, different indexes should use their own keys type
   instead of using the keys type of base table uniformly.
   `
   2. There are two kinds of define expr in Column , one is analyzed, and the 
other is not analyzed.
   Currently, analyzed define expr is only used when creating materialized 
views, so the define expr in RollupJob must be analyzed.
   In other cases, such as define expr in `MaterializedIndexMeta`, it may not 
be analyzed after being relayed.
   When executing the load, the analyzed define expr (such as 
to_bitmap(cast(k1, varchar))) will not be analyzed again.
   Only a cast function will be added to the inner layer(such as 
to_bitmap(cast(cast(k1 ,int), varchar))) which is analyzed too.
   The define expr that has not been analyzed (such as cast(k1, varchar)) will 
be analyzed when executing the load.
   
   Change-Id: Ibd78148e8182f94e1a73b6ec1611d2770215b8a4
   
   Fixed #4342
   Fixed #4271
   
   ## Proposed changes
   
   Describe the big picture of your changes here to communicate to the 
maintainers why we should accept this pull request. If it fixes a bug or 
resolves a feature request, be sure to link to that issue.
   
   ## Types of changes
   
   What types of changes does your code introduce to Doris?
   _Put an `x` in the boxes that apply_
   
   - [x] Bugfix (non-breaking change which fixes an issue)
   - [] New feature (non-breaking change which adds functionality)
   - [] Breaking change (fix or feature that would cause existing functionality 
to not work as expected)
   - [] Documentation Update (if none of the other choices apply)
   - [] Code refactor (Modify the code structure, format the code, etc...)
   
   ## Checklist
   
   _Put an `x` in the boxes that apply. You can also fill these out after 
creating the PR. If you're unsure about any of them, don't hesitate to ask. 
We're here to help! This is simply a reminder of what we are going to look for 
before merging your code._
   
   - [x] I have create an issue on (Fix #ISSUE), and have described the 
bug/feature there in detail
   - [x] Compiling and unit tests pass locally with my changes
   - [] I have added tests that prove my fix is effective or that my feature 
works
   - [] If this change need a document change, I have updated the document
   - [] Any dependent changes have been merged
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to