yiguolei commented on code in PR #22442:
URL: https://github.com/apache/doris/pull/22442#discussion_r1293032407
##########
be/src/olap/delete_handler.cpp:
##########
@@ -259,21 +303,14 @@ Status DeleteHandler::init(TabletSchemaSPtr tablet_schema,
auto& delete_condition = delete_pred->delete_predicate();
DeleteConditions temp;
temp.filter_version = delete_pred->version().first;
- for (const auto& sub_predicate : delete_condition.sub_predicates()) {
- TCondition condition;
- if (!_parse_condition(sub_predicate, &condition)) {
- return Status::Error<DELETE_INVALID_PARAMETERS>(
- "fail to parse condition. condition={}",
sub_predicate);
- }
- condition.__set_column_unique_id(
-
delete_pred_related_schema->column(condition.column_name).unique_id());
- auto predicate =
- parse_to_predicate(tablet_schema, condition,
_predicate_arena.get(), true);
- if (predicate != nullptr) {
- temp.column_predicate_vec.push_back(predicate);
- }
+ if (delete_condition.sub_predicates_size() == 0) {
+ RETURN_IF_ERROR(_parse_column_pred(delete_pred_related_schema,
+
delete_condition.sub_predicates_v2(), &temp));
+ } else {
+ // make it compatible with the former versions
Review Comment:
a int, b int
delete where a = 1
rename a --> c
drop column a
add column a string
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
