kaijchen opened a new pull request, #23019:
URL: https://github.com/apache/doris/pull/23019
## Proposed changes
Use smart pointer to manage MemTableWriters in MemTableMemoryLimiter.
We no longer need to deregister writers in MemTableMemoryLimiter.
### Test
The log is changed to VLOG_DEBUG in the final version.
```
I0815 20:44:14.725538 1158747 vtablet_sink.cpp:1584] finished to close olap
table sink. load_id=db481b50e1a84028-8216c3dab1a7c0b3, txn_id=16020, node add
batch time(ms)/wait execution time(ms)/close time(ms)/num:
{10039:(570)(0)(674)(2)} {10040:(389)(0)(528)(2)} {10041:(491)(0)(528)(2)}
I0815 20:44:14.729375 1158747 query_context.h:69] Deregister query/load
memory tracker, queryId=db481b50e1a84028-8216c3dab1a7c0b3, Limit=2.00 GB,
CurrUsed=32.84 MB, PeakUsed=379.68 MB
I0815 20:44:14.795511 1158496 memtable_memory_limiter.cpp:226] refreshed
mem_tracker, num writers: 2304
I0815 20:44:14.895648 1158496 memtable_memory_limiter.cpp:226] refreshed
mem_tracker, num writers: 2304
I0815 20:44:14.995826 1158496 memtable_memory_limiter.cpp:226] refreshed
mem_tracker, num writers: 2304
I0815 20:44:15.095990 1158496 memtable_memory_limiter.cpp:226] refreshed
mem_tracker, num writers: 2304
I0815 20:44:15.196146 1158496 memtable_memory_limiter.cpp:226] refreshed
mem_tracker, num writers: 2304
I0815 20:44:15.296309 1158496 memtable_memory_limiter.cpp:226] refreshed
mem_tracker, num writers: 2304
I0815 20:44:15.396457 1158496 memtable_memory_limiter.cpp:226] refreshed
mem_tracker, num writers: 2304
I0815 20:44:15.407001 1161561 load_channel.cpp:49] load channel removed
load_id=db481b50e1a84028-8216c3dab1a7c0b3, is high priority=0,
sender_ip=10.16.10.7
I0815 20:44:15.496557 1158496 memtable_memory_limiter.cpp:226] refreshed
mem_tracker, num writers: 0
```
## Further comments
If this is a relatively large or complex change, kick off the discussion at
[[email protected]](mailto:[email protected]) by explaining why you
chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
