AshinGau commented on code in PR #23015:
URL: https://github.com/apache/doris/pull/23015#discussion_r1296837935
##########
fe/be-java-extensions/java-udf/pom.xml:
##########
@@ -47,6 +63,170 @@ under the License.
<artifactId>reflectasm</artifactId>
<version>1.11.9</version>
</dependency>
+ <dependency>
Review Comment:
Why add so many dependencies in java-udf?
##########
fe/pom.xml:
##########
@@ -1041,7 +1041,7 @@ under the License.
<groupId>org.apache.spark</groupId>
<artifactId>spark-core_2.12</artifactId>
<version>${spark.version}</version>
- <scope>provided</scope>
+ <scope>compile</scope>
Review Comment:
Why change the scope from `provided` to `compile`?
##########
fe/be-java-extensions/java-common/pom.xml:
##########
@@ -60,5 +60,29 @@ under the License.
<artifactId>jackson-databind</artifactId>
</dependency>
</dependencies>
-
+ <build>
+ <plugins>
Review Comment:
Why add scala plugin in java-common?
##########
fe/be-java-extensions/avro-scanner/pom.xml:
##########
@@ -41,16 +41,6 @@ under the License.
<artifactId>java-common</artifactId>
<version>${project.version}</version>
</dependency>
- <dependency>
Review Comment:
Why remove avro dependency in avro-scanner?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
