This is an automated email from the ASF dual-hosted git repository. kxiao pushed a commit to branch branch-2.0 in repository https://gitbox.apache.org/repos/asf/doris.git
commit 3af1a1f1e8af085ed297b56a5bf94308f4f78d1e Author: jakevin <[email protected]> AuthorDate: Tue Aug 15 13:14:20 2023 +0800 [chore](Nereids): remove useless code (#22960) --- .../java/org/apache/doris/nereids/trees/plans/GroupPlan.java | 6 ------ .../nereids/trees/plans/logical/AbstractLogicalPlan.java | 9 --------- .../nereids/trees/plans/logical/LogicalSetOperation.java | 11 +---------- 3 files changed, 1 insertion(+), 25 deletions(-) diff --git a/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/GroupPlan.java b/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/GroupPlan.java index 0d4d278abf..bbd5f8afb2 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/GroupPlan.java +++ b/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/GroupPlan.java @@ -86,12 +86,6 @@ public class GroupPlan extends LogicalLeaf { + " You should invoke GroupPlan.getOutput()"); } - @Override - public LogicalProperties computeLogicalProperties() { - throw new IllegalStateException("GroupPlan can not compute logical properties." - + " You should invoke GroupPlan.getLogicalProperties()"); - } - @Override public <R, C> R accept(PlanVisitor<R, C> visitor, C context) { return visitor.visitGroupPlan(this, context); diff --git a/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/AbstractLogicalPlan.java b/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/AbstractLogicalPlan.java index 7504863ea9..738486f448 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/AbstractLogicalPlan.java +++ b/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/AbstractLogicalPlan.java @@ -27,15 +27,11 @@ import org.apache.doris.qe.ConnectContext; import java.util.List; import java.util.Optional; -import java.util.function.Supplier; /** * Abstract class for all concrete logical plan. */ public abstract class AbstractLogicalPlan extends AbstractPlan implements LogicalPlan, Explainable { - - private final Supplier<Boolean> hasUnboundExpressions = super::hasUnboundExpression; - public AbstractLogicalPlan(PlanType type, Plan... children) { super(type, children); } @@ -50,11 +46,6 @@ public abstract class AbstractLogicalPlan extends AbstractPlan implements Logica super(type, groupExpression, logicalProperties, null, children); } - @Override - public boolean hasUnboundExpression() { - return hasUnboundExpressions.get(); - } - @Override public Plan getExplainPlan(ConnectContext ctx) { return this; diff --git a/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalSetOperation.java b/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalSetOperation.java index 72a4996ece..68088d8289 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalSetOperation.java +++ b/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalSetOperation.java @@ -20,7 +20,6 @@ package org.apache.doris.nereids.trees.plans.logical; import org.apache.doris.catalog.Type; import org.apache.doris.nereids.memo.GroupExpression; import org.apache.doris.nereids.properties.LogicalProperties; -import org.apache.doris.nereids.properties.UnboundLogicalProperties; import org.apache.doris.nereids.trees.expressions.Alias; import org.apache.doris.nereids.trees.expressions.Cast; import org.apache.doris.nereids.trees.expressions.Expression; @@ -86,15 +85,7 @@ public abstract class LogicalSetOperation extends AbstractLogicalPlan implements @Override public boolean hasUnboundExpression() { - return outputs.isEmpty() || super.hasUnboundExpression(); - } - - @Override - public LogicalProperties computeLogicalProperties() { - if (outputs.isEmpty()) { - return UnboundLogicalProperties.INSTANCE; - } - return super.computeLogicalProperties(); + return outputs.isEmpty(); } @Override --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
