yiguolei commented on code in PR #23053:
URL: https://github.com/apache/doris/pull/23053#discussion_r1297893777
##########
be/src/runtime/exec_env_init.cpp:
##########
@@ -170,6 +171,7 @@ Status ExecEnv::_init(const std::vector<StorePath>&
store_paths) {
_block_spill_mgr = new BlockSpillManager(_store_paths);
_file_meta_cache = new
FileMetaCache(config::max_external_file_meta_cache_num);
_memtable_memory_limiter = std::make_unique<MemTableMemoryLimiter>();
+ _wal_manager = new WalManager(this, config::group_commit_replay_wal_dir);
Review Comment:
use smart pointer, not use raw pointer.
Add ENABLE_FACTORY_CREATOR to all classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
