Lchangliang commented on code in PR #22557:
URL: https://github.com/apache/doris/pull/22557#discussion_r1297927729
##########
be/src/exec/tablet_info.cpp:
##########
@@ -66,30 +68,31 @@ Status OlapTableSchemaParam::init(const
POlapTableSchemaParam& pschema) {
for (auto& col : pschema.partial_update_input_columns()) {
_partial_update_input_columns.insert(col);
}
- std::map<std::string, SlotDescriptor*> slots_map;
+ std::unordered_map<std::pair<std::string, std::string>, SlotDescriptor*>
slots_map;
_tuple_desc = _obj_pool.add(new TupleDescriptor(pschema.tuple_desc()));
for (auto& p_slot_desc : pschema.slot_descs()) {
auto slot_desc = _obj_pool.add(new SlotDescriptor(p_slot_desc));
_tuple_desc->add_slot(slot_desc);
- slots_map.emplace(slot_desc->col_name(), slot_desc);
+ string data_type;
+ EnumToString(TPrimitiveType, to_thrift(slot_desc->col_type()),
data_type);
Review Comment:
When we init the tablet column, the field `column_type` will change from
TPrimitiveType to string by this method to FieldType by
`TabletColumn::get_field_type_by_string`. And the column type in columnPB is
string and it changed from TPrimitiveType.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
