morningman commented on code in PR #23198:
URL: https://github.com/apache/doris/pull/23198#discussion_r1299390683
##########
be/src/vec/exec/format/parquet/vparquet_reader.cpp:
##########
@@ -322,22 +322,27 @@ Status ParquetReader::init_reader(
// e.g. table added a column after this parquet file was written.
_column_names = &all_column_names;
auto schema_desc = _file_metadata->schema();
+ std::set<std::string> required_columns(all_column_names.begin(),
all_column_names.end());
+ std::set<std::string> dropped_columns(missing_column_names.begin(),
missing_column_names.end());
+ // Make the order of read columns the same as physical order in parquet
file
for (int i = 0; i < schema_desc.size(); ++i) {
auto name = schema_desc.get_column(i)->name;
// If the column in parquet file is included in all_column_names and
not in missing_column_names,
// add it to _map_column, which means the reader should read the data
of this column.
Review Comment:
Need to change the comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
