github-actions[bot] commented on PR #23290:
URL: https://github.com/apache/doris/pull/23290#issuecomment-1687029115
#### `sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/5931344934";) output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In thirdparty/build-thirdparty.sh line 432:
-DCMAKE_PREFIX_PATH=${TP_INSTALL_DIR} \
^---------------^ SC2086 (info): Double quote to
prevent globbing and word splitting.
Did you mean:
-DCMAKE_PREFIX_PATH="${TP_INSTALL_DIR}" \
In thirdparty/build-thirdparty.sh line 439:
-DCMAKE_INSTALL_PREFIX=${TP_INSTALL_DIR} ../..
^---------------^ SC2086 (info): Double quote
to prevent globbing and word splitting.
Did you mean:
-DCMAKE_INSTALL_PREFIX="${TP_INSTALL_DIR}" ../..
In thirdparty/build-thirdparty.sh line 935:
-DCMAKE_INSTALL_PREFIX=${TP_INSTALL_DIR} ..
^---------------^ SC2086 (info): Double quote
to prevent globbing and word splitting.
Did you mean:
-DCMAKE_INSTALL_PREFIX="${TP_INSTALL_DIR}" ..
In thirdparty/build-thirdparty.sh line 951:
-DCMAKE_INSTALL_PREFIX=${TP_INSTALL_DIR} \
^---------------^ SC2086 (info): Double quote
to prevent globbing and word splitting.
Did you mean:
-DCMAKE_INSTALL_PREFIX="${TP_INSTALL_DIR}" \
In thirdparty/build-thirdparty.sh line 953:
-Dc-ares_DIR=${TP_INSTALL_DIR} \
^---------------^ SC2086 (info): Double quote to prevent
globbing and word splitting.
Did you mean:
-Dc-ares_DIR="${TP_INSTALL_DIR}" \
In thirdparty/build-thirdparty.sh line 955:
-Dabsl_DIR=${TP_INSTALL_DIR} \
^---------------^ SC2086 (info): Double quote to prevent
globbing and word splitting.
Did you mean:
-Dabsl_DIR="${TP_INSTALL_DIR}" \
In thirdparty/build-thirdparty.sh line 957:
-DProtobuf_DIR=${TP_INSTALL_DIR} \
^---------------^ SC2086 (info): Double quote to
prevent globbing and word splitting.
Did you mean:
-DProtobuf_DIR="${TP_INSTALL_DIR}" \
In thirdparty/build-thirdparty.sh line 959:
-Dre2_DIR:STRING=${TP_INSTALL_DIR} \
^---------------^ SC2086 (info): Double quote to
prevent globbing and word splitting.
Did you mean:
-Dre2_DIR:STRING="${TP_INSTALL_DIR}" \
In thirdparty/build-thirdparty.sh line 961:
-DOPENSSL_ROOT_DIR=${TP_INSTALL_DIR} \
^---------------^ SC2086 (info): Double quote to
prevent globbing and word splitting.
Did you mean:
-DOPENSSL_ROOT_DIR="${TP_INSTALL_DIR}" \
In thirdparty/build-thirdparty.sh line 963:
-DZLIB_ROOT=${TP_INSTALL_DIR} \
^---------------^ SC2086 (info): Double quote to prevent
globbing and word splitting.
Did you mean:
-DZLIB_ROOT="${TP_INSTALL_DIR}" \
In thirdparty/build-thirdparty.sh line 971:
sed -i 's/find_dependency/find_package/g'
${TP_INSTALL_DIR}/lib64/cmake/grpc/gRPCConfig.cmake
^---------------^ SC2086
(info): Double quote to prevent globbing and word splitting.
Did you mean:
sed -i 's/find_dependency/find_package/g'
"${TP_INSTALL_DIR}"/lib64/cmake/grpc/gRPCConfig.cmake
For more information:
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing
...
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' returned error 1 finding the following formatting issues:
----------
--- thirdparty/build-thirdparty.sh.orig
+++ thirdparty/build-thirdparty.sh
@@ -427,7 +427,7 @@
cd cmake/build
CXXFLAGS="-O2 -I${TP_INCLUDE_DIR}" \
- LDFLAGS="${ldflags}" \
+ LDFLAGS="${ldflags}" \
"${CMAKE_CMD}" -DCMAKE_BUILD_TYPE=Release \
-DCMAKE_PREFIX_PATH=${TP_INSTALL_DIR} \
-Dprotobuf_USE_EXTERNAL_GTEST=ON \
@@ -946,23 +946,23 @@
cd cmake/build
cmake -DgRPC_INSTALL=ON \
- -DgRPC_BUILD_TESTS=OFF \
- -DCMAKE_BUILD_TYPE=Release \
- -DCMAKE_INSTALL_PREFIX=${TP_INSTALL_DIR} \
- -DgRPC_CARES_PROVIDER=package \
- -Dc-ares_DIR=${TP_INSTALL_DIR} \
- -DgRPC_ABSL_PROVIDER=package \
- -Dabsl_DIR=${TP_INSTALL_DIR} \
- -DgRPC_PROTOBUF_PROVIDER=package \
- -DProtobuf_DIR=${TP_INSTALL_DIR} \
- -DgRPC_RE2_PROVIDER=package \
- -Dre2_DIR:STRING=${TP_INSTALL_DIR} \
- -DgRPC_SSL_PROVIDER=package \
- -DOPENSSL_ROOT_DIR=${TP_INSTALL_DIR} \
- -DgRPC_ZLIB_PROVIDER=package \
- -DZLIB_ROOT=${TP_INSTALL_DIR} \
- -DCMAKE_POSITION_INDEPENDENT_CODE=ON \
- ../..
+ -DgRPC_BUILD_TESTS=OFF \
+ -DCMAKE_BUILD_TYPE=Release \
+ -DCMAKE_INSTALL_PREFIX=${TP_INSTALL_DIR} \
+ -DgRPC_CARES_PROVIDER=package \
+ -Dc-ares_DIR=${TP_INSTALL_DIR} \
+ -DgRPC_ABSL_PROVIDER=package \
+ -Dabsl_DIR=${TP_INSTALL_DIR} \
+ -DgRPC_PROTOBUF_PROVIDER=package \
+ -DProtobuf_DIR=${TP_INSTALL_DIR} \
+ -DgRPC_RE2_PROVIDER=package \
+ -Dre2_DIR:STRING=${TP_INSTALL_DIR} \
+ -DgRPC_SSL_PROVIDER=package \
+ -DOPENSSL_ROOT_DIR=${TP_INSTALL_DIR} \
+ -DgRPC_ZLIB_PROVIDER=package \
+ -DZLIB_ROOT=${TP_INSTALL_DIR} \
+ -DCMAKE_POSITION_INDEPENDENT_CODE=ON \
+ ../..
make -j "${PARALLEL}"
make install
@@ -1579,8 +1579,8 @@
cd "${BUILD_DIR}"
CXXFLAGS="-O2 -I${TP_INCLUDE_DIR}" \
- LDFLAGS="-L${TP_LIB_DIR}" \
- "${CMAKE_CMD}" -G "${GENERATOR}"
-DCMAKE_INSTALL_PREFIX="${TP_INSTALL_DIR}" \
+ LDFLAGS="-L${TP_LIB_DIR}" \
+ "${CMAKE_CMD}" -G "${GENERATOR}"
-DCMAKE_INSTALL_PREFIX="${TP_INSTALL_DIR}" \
-DCMAKE_PREFIX_PATH="${TP_INSTALL_DIR}" \
-DBUILD_TESTING=OFF \
-DWITH_OTLP_GRPC=ON \
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
