zclllyybb commented on code in PR #23310:
URL: https://github.com/apache/doris/pull/23310#discussion_r1301623276


##########
be/src/vec/functions/function_json.cpp:
##########
@@ -1064,6 +1064,187 @@ class FunctionJsonContains : public IFunction {
     }
 };
 
+class FunctionJsonMergePatch : public IFunction {
+public:
+    static constexpr auto name = "json_merge_patch";
+    static FunctionPtr create() { return 
std::make_shared<FunctionJsonMergePatch>(); }
+
+    String get_name() const override { return name; }
+
+    size_t get_number_of_arguments() const override { return 0; }
+
+    bool is_variadic() const override { return true; }
+
+    DataTypePtr get_return_type_impl(const DataTypes& arguments) const 
override {
+        return make_nullable(std::make_shared<DataTypeString>());

Review Comment:
   Does it need to be always_nullable? for not_nullable inputs, it seems will 
not generate null value?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to