yiguolei commented on code in PR #23318:
URL: https://github.com/apache/doris/pull/23318#discussion_r1302328310


##########
be/src/olap/rowset/segment_v2/segment.cpp:
##########
@@ -367,14 +367,14 @@ Status Segment::lookup_row_key(const Slice& key, bool 
with_seq_col, RowLocation*
 
     DCHECK(_pk_index_reader != nullptr);
     if (!_pk_index_reader->check_present(key_without_seq)) {
-        return Status::NotFound("Can't find key in the segment");
+        return Status::NotFound("");

Review Comment:
   Is this pr will really improve performance???
   Could you please provide some performance number?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to