LHG41278 commented on code in PR #22048:
URL: https://github.com/apache/doris/pull/22048#discussion_r1302916724
##########
be/src/olap/storage_policy.cpp:
##########
@@ -48,7 +48,7 @@ Status get_remote_file_system(int64_t storage_policy_id,
return Status::InternalError("could not find resource, resouce_id={}",
storage_policy->resource_id);
}
- DCHECK(atol((*fs)->id().c_str()) == storage_policy->resource_id);
+ // DCHECK(atol((*fs)->id().c_str()) == storage_policy->resource_id);
Review Comment:
This DCHECK macro is unnecessary because the field id is not initialized in
the constructor of the class HdfsFileSystem,and neither the derived class nor
the base class don't expose the interface of modifying such field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
