github-actions[bot] commented on PR #23406:
URL: https://github.com/apache/doris/pull/23406#issuecomment-1690002857
#### `sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/5952217310";) output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In bin/start_be.sh line 96:
if [ -d "$custom_extension_folder" ]; then
^-- SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
^----------------------^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
Did you mean:
if [[ -d "${custom_extension_folder}" ]]; then
In bin/start_be.sh line 97:
for file in "$custom_extension_folder"/*.jar ; do
^----------------------^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
Did you mean:
for file in "${custom_extension_folder}"/*.jar ; do
For more information:
https://www.shellcheck.net/wiki/SC2250 -- Prefer putting braces around
vari...
https://www.shellcheck.net/wiki/SC2292 -- Prefer [[ ]] over [ ] for tests
i...
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' returned error 1 finding the following formatting issues:
----------
--- bin/start_be.sh.orig
+++ bin/start_be.sh
@@ -94,9 +94,9 @@
custom_extension_folder="${DORIS_HOME}/lib/java_extensions/custom_extension"
if [ -d "$custom_extension_folder" ]; then
- for file in "$custom_extension_folder"/*.jar ; do
- export DORIS_CLASSPATH="${DORIS_CLASSPATH}:${file}"
- done
+ for file in "$custom_extension_folder"/*.jar; do
+ export DORIS_CLASSPATH="${DORIS_CLASSPATH}:${file}"
+ done
fi
if [[ -d "${DORIS_HOME}/lib/hadoop_hdfs/" ]]; then
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
