morningman commented on code in PR #23486:
URL: https://github.com/apache/doris/pull/23486#discussion_r1307301627
##########
be/src/io/fs/buffered_reader.h:
##########
@@ -238,15 +238,15 @@ class MergeRangeFileReader : public io::FileReader {
/**
* Create a file reader suitable for accessing scenarios:
- * 1. When file size < 8MB, create InMemoryFileReader file reader
+ * 1. When file size < 1MB, create InMemoryFileReader file reader
* 2. When reading sequential file(csv/json), create PrefetchBufferedReader
* 3. When reading random access file(parquet/orc), create normal file reader
*/
class DelegateReader {
public:
enum AccessMode { SEQUENTIAL, RANDOM };
- static constexpr size_t IN_MEMORY_FILE_SIZE = 8 * 1024 * 1024;
+ static constexpr size_t IN_MEMORY_FILE_SIZE = 1 * 1024 * 1024;
Review Comment:
better be a config?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
