gavinchou commented on code in PR #22442:
URL: https://github.com/apache/doris/pull/22442#discussion_r1307358370
##########
be/src/olap/delete_handler.cpp:
##########
@@ -112,6 +147,23 @@ std::string DeleteHandler::construct_sub_predicates(const
TCondition& condition)
return condition_str;
}
+std::string DeleteHandler::trans_op(const std::string& opt) {
+ std::string op = string(opt);
Review Comment:
This function should not be a member function of DeleteHandler, make it
static free function in delete_handler.cpp, because it does not rely on any
state of the instantiated class DeleteHandler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
