XieJiann commented on code in PR #23271:
URL: https://github.com/apache/doris/pull/23271#discussion_r1309575491
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/SubqueryToApply.java:
##########
@@ -116,36 +112,44 @@ public List<Rule> buildRules() {
return new LogicalFilter<>(conjuncts, applyPlan);
})
),
- RuleType.PROJECT_SUBQUERY_TO_APPLY.build(
- logicalProject().thenApply(ctx -> {
- LogicalProject<Plan> project = ctx.root;
- Set<SubqueryExpr> subqueryExprs = new LinkedHashSet<>();
- project.getProjects().stream()
- .filter(Alias.class::isInstance)
- .map(Alias.class::cast)
- .filter(alias -> alias.child() instanceof CaseWhen)
- .forEach(alias -> alias.child().children().stream()
- .forEach(e ->
-
subqueryExprs.addAll(e.collect(SubqueryExpr.class::isInstance))));
- if (subqueryExprs.isEmpty()) {
- return project;
- }
-
- SubqueryContext context = new
SubqueryContext(subqueryExprs);
- return new LogicalProject(project.getProjects().stream()
- .map(p -> p.withChildren(
- new ReplaceSubquery(ctx.statementContext, true)
- .replace(p, context)))
- .collect(ImmutableList.toImmutableList()),
- subqueryToApply(
-
subqueryExprs.stream().collect(ImmutableList.toImmutableList()),
- (LogicalPlan) project.child(),
- context.getSubqueryToMarkJoinSlot(),
- ctx.cascadesContext,
- Optional.empty(), true
- ));
- })
- )
+
RuleType.PROJECT_SUBQUERY_TO_APPLY.build(logicalProject().thenApply(ctx -> {
+ LogicalProject<Plan> project = ctx.root;
+ ImmutableList<Set<SubqueryExpr>> subqueryExprsList =
project.getProjects().stream()
+ .map(e -> (Set<SubqueryExpr>)
e.collect(SubqueryExpr.class::isInstance))
+ .collect(ImmutableList.toImmutableList());
+ if
(subqueryExprsList.stream().flatMap(Collection::stream).count() == 0) {
+ return project;
+ }
+ List<NamedExpression> oldProjects =
ImmutableList.copyOf(project.getProjects());
Review Comment:
This copy is redundant?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
