morrySnow commented on code in PR #23613:
URL: https://github.com/apache/doris/pull/23613#discussion_r1311227406
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/CreateTableAsSelectStmt.java:
##########
@@ -82,6 +84,10 @@ public void analyze(Analyzer analyzer) throws UserException {
queryStmt.getResultExprs().get(i).getSrcSlotRef().getColumn()
.setIsAllowNull(outputs.get(i).isNullable());
}
+ if (Config.disable_datev1 &&
queryStmt.getResultExprs().get(i).getType() == Type.DATE) {
Review Comment:
i think we should use `Config.enable_date_conversion`?
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/CreateTableAsSelectStmt.java:
##########
@@ -82,6 +84,10 @@ public void analyze(Analyzer analyzer) throws UserException {
queryStmt.getResultExprs().get(i).getSrcSlotRef().getColumn()
.setIsAllowNull(outputs.get(i).isNullable());
}
+ if (Config.disable_datev1 &&
queryStmt.getResultExprs().get(i).getType() == Type.DATE) {
Review Comment:
process datetime and decimal too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
