JNSimba commented on code in PR #187:
URL:
https://github.com/apache/doris-flink-connector/pull/187#discussion_r1311267839
##########
flink-doris-connector/src/main/java/org/apache/doris/flink/cfg/DorisOptions.java:
##########
@@ -109,9 +125,12 @@ public Builder setJdbcUrl(String jdbcUrl) {
public DorisOptions build() {
checkNotNull(fenodes, "No fenodes supplied.");
checkNotNull(tableIdentifier, "No tableIdentifier supplied.");
+ if (StringUtils.isNotEmpty(beNodes)) {
+ return new DorisOptions(fenodes, beNodes, username, password,
tableIdentifier, jdbcUrl);
+ }
return new DorisOptions(fenodes, username, password,
tableIdentifier, jdbcUrl);
+
Review Comment:
maybe directly `new DorisOptions(fenodes, beNodes, username, password,
tableIdentifier, jdbcUrl);` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
