morningman commented on code in PR #23682:
URL: https://github.com/apache/doris/pull/23682#discussion_r1311848383
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/OlapTable.java:
##########
@@ -936,7 +933,11 @@ public Partition dropPartition(long dbId, String
partitionName, boolean isForceD
// get partition by name, not including temp partitions
@Override
public Partition getPartition(String partitionName) {
Review Comment:
Why change the behavior of this method?
The comment of this method show that it should not include temp partition
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/PartitionKeyDesc.java:
##########
@@ -28,6 +28,7 @@
// Describe the partition key values in create table or add partition clause
public class PartitionKeyDesc {
public static final PartitionKeyDesc MAX_VALUE = new PartitionKeyDesc();
+ public static final PartitionKeyDesc DUMMY_KEY_DESC = new
PartitionKeyDesc();
Review Comment:
Add comment in code to explain why we need this field
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/InsertIntoTableCommand.java:
##########
@@ -151,6 +179,145 @@ public void run(ConnectContext ctx, StmtExecutor
executor) throws Exception {
}
}
+ /**
+ * when `isOverwrite` is true,use this logic
Review Comment:
```suggestion
* when `isOverwrite` is true, use this logic
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
