airborne12 commented on code in PR #23581:
URL: https://github.com/apache/doris/pull/23581#discussion_r1312423789
##########
be/src/vec/columns/predicate_column.h:
##########
@@ -154,8 +153,16 @@ class PredicateColumnType final : public
COWHelper<IColumn, PredicateColumnType<
size_t size() const override { return data.size(); }
- [[noreturn]] StringRef get_data_at(size_t n) const override {
- LOG(FATAL) << "get_data_at not supported in PredicateColumnType";
+ StringRef get_data_at(size_t n) const override {
+ if constexpr (std::is_same_v<T, StringRef>) {
+ auto res = reinterpret_cast<const StringRef&>(data[n]);
+ if constexpr (Type == TYPE_CHAR) {
+ res.size = strnlen(res.data, res.size);
Review Comment:
it has to be trimed \0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
