yiguolei commented on code in PR #23746:
URL: https://github.com/apache/doris/pull/23746#discussion_r1312640835
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/FunctionSet.java:
##########
@@ -345,10 +345,10 @@ private Function getFunction(Function desc,
Function.CompareMode mode, List<Func
public Function specializeTemplateFunction(Function templateFunction,
Function requestFunction, boolean isVariadic) {
try {
boolean hasTemplateType = false;
- LOG.debug("templateFunction signature: " +
templateFunction.signatureString()
- + " return: " + templateFunction.getReturnType());
- LOG.debug("requestFunction signature: " +
requestFunction.signatureString()
- + " return: " + requestFunction.getReturnType());
+ LOG.debug("templateFunction signature: {}, return type: {}",
Review Comment:
if (Log.isdebugenabled()) {
xxxx
}
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/FunctionSet.java:
##########
@@ -397,12 +397,12 @@ public Function specializeTemplateFunction(Function
templateFunction, Function r
specializedFunction.getReturnType().specializeTemplateType(
requestFunction.getReturnType(), specializedTypeMap,
true));
}
- LOG.debug("specializedFunction signature: " +
specializedFunction.signatureString()
- + " return: " + specializedFunction.getReturnType());
+ LOG.debug("specializedFunction signature: {}, return type: {}",
Review Comment:
if (Log.isdebugenabled()) {
xxxx
}
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/FunctionSet.java:
##########
@@ -397,12 +397,12 @@ public Function specializeTemplateFunction(Function
templateFunction, Function r
specializedFunction.getReturnType().specializeTemplateType(
requestFunction.getReturnType(), specializedTypeMap,
true));
}
- LOG.debug("specializedFunction signature: " +
specializedFunction.signatureString()
- + " return: " + specializedFunction.getReturnType());
+ LOG.debug("specializedFunction signature: {}, return type: {}",
+ specializedFunction.signatureString(),
specializedFunction.getReturnType());
return hasTemplateType ? specializedFunction : templateFunction;
} catch (TypeException e) {
if (inited) {
- LOG.warn("specializeTemplateFunction exception", e);
+ LOG.debug("specializeTemplateFunction exception", e);
Review Comment:
if (Log.isdebugenabled()) {
xxxx
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
