xiaokang commented on code in PR #23779:
URL: https://github.com/apache/doris/pull/23779#discussion_r1313720228
##########
be/src/olap/rowset/segment_v2/column_writer.cpp:
##########
@@ -729,6 +734,65 @@ Status ScalarColumnWriter::finish_current_page() {
return Status::OK();
}
+Status ScalarColumnWriter::finish_current_page(const uint8_t* next_data_ptr) {
Review Comment:
Should not add a function with almost duplicate code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
