github-actions[bot] commented on code in PR #23862:
URL: https://github.com/apache/doris/pull/23862#discussion_r1314703778
##########
be/test/util/quantile_state_test.cpp:
##########
@@ -38,7 +37,7 @@
EXPECT_EQ(3, empty.get_value_by_percentile(0.5));
EXPECT_EQ(5, empty.get_value_by_percentile(1));
- DoubleQuantileState another;
+ QuantileState another;
Review Comment:
warning: variable 'another' is not initialized
[cppcoreguidelines-init-variables]
```suggestion
QuantileState another = 0;
```
##########
be/test/util/quantile_state_test.cpp:
##########
@@ -23,10 +23,9 @@
#include "gtest/gtest_pred_impl.h"
namespace doris {
-using DoubleQuantileState = QuantileState<double>;
TEST(QuantileStateTest, merge) {
- DoubleQuantileState empty;
+ QuantileState empty;
Review Comment:
warning: variable 'empty' is not initialized
[cppcoreguidelines-init-variables]
```suggestion
QuantileState empty = 0;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
