github-actions[bot] commented on code in PR #23984:
URL: https://github.com/apache/doris/pull/23984#discussion_r1317046407
##########
be/test/http/http_client_test.cpp:
##########
@@ -177,4 +186,21 @@ TEST_F(HttpClientTest, post_failed) {
EXPECT_TRUE(boost::algorithm::contains(st.to_string(), not_found));
}
+TEST_F(HttpClientTest, not_found) {
+ HttpClient client;
Review Comment:
warning: variable 'client' is not initialized
[cppcoreguidelines-init-variables]
```suggestion
HttpClient client = 0;
```
##########
be/test/http/http_client_test.cpp:
##########
@@ -177,4 +186,21 @@
EXPECT_TRUE(boost::algorithm::contains(st.to_string(), not_found));
}
+TEST_F(HttpClientTest, not_found) {
+ HttpClient client;
+ std::string url = hostname + "/not_found";
+ constexpr uint64_t kMaxTimeoutMs = 1000;
+
+ auto get_cb = [&url](HttpClient* client) {
+ std::string resp;
Review Comment:
warning: variable 'resp' is not initialized
[cppcoreguidelines-init-variables]
```suggestion
std::string resp = 0;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
