sohardforaname commented on code in PR #23121:
URL: https://github.com/apache/doris/pull/23121#discussion_r1318302034
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/BindSink.java:
##########
@@ -116,8 +118,13 @@ public List<Rule> buildRules() {
"mv column's ref column cannot
be null");
Expression parsedExpression =
expressionParser.parseExpression(
column.getDefineExpr().toSql());
- Expression boundExpression =
SlotReplacer.INSTANCE
+ Expression boundSlotExpression =
SlotReplacer.INSTANCE
.replace(parsedExpression,
columnToOutput);
+ // the boundSlotExpression is an
expression whose slots are bound but function
+ // may not be bound, we have to bind
it again.
+ // for example: to_bitmap.
+ Expression boundExpression =
FunctionBinder.INSTANCE.rewrite(
+ boundSlotExpression, new
ExpressionRewriteContext(ctx.cascadesContext));
Review Comment:
yes, it's from p0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
