xinyiZzz commented on code in PR #23385:
URL: https://github.com/apache/doris/pull/23385#discussion_r1320959257
##########
be/src/olap/primary_key_index.cpp:
##########
@@ -32,7 +32,9 @@
#include "olap/types.h"
namespace doris {
-
+PrimaryKeyIndexBuilder::~PrimaryKeyIndexBuilder() {
+
_bloom_filter_index_mem_tracker->release(_bloom_filter_index_mem_tracker->consumption());
Review Comment:
`MemTracker` does not need to release itself during destruction.
Because `MemTracker` is an independent entity and will not exist after
destruction.
Of course that's okay
##########
be/src/runtime/memory/mem_tracker_limiter.cpp:
##########
@@ -229,6 +229,7 @@ std::string MemTrackerLimiter::log_process_usage_str() {
std::vector<MemTracker::Snapshot> snapshots;
MemTrackerLimiter::make_process_snapshots(&snapshots);
MemTrackerLimiter::make_type_snapshots(&snapshots,
MemTrackerLimiter::Type::GLOBAL);
+ MemTrackerLimiter::make_type_snapshots(&snapshots,
MemTrackerLimiter::Type::COMPACTION);
Review Comment:
Only print `Label=BaseCompaction`, do not print its child tracker, otherwise
it may print a lot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
