jackwener commented on code in PR #24171:
URL: https://github.com/apache/doris/pull/24171#discussion_r1320966205
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/util/DateUtils.java:
##########
@@ -89,7 +89,9 @@ public static DateTimeFormatterBuilder formatBuilder(String
pattern) throws Anal
break;
case 'r': // %r Time, 12-hour (hh:mm:ss followed by AM or
PM)
builder.appendValue(ChronoField.HOUR_OF_AMPM, 2)
- .appendPattern(":mm:ss ")
+ .appendValue(ChronoField.MINUTE_OF_HOUR, 2)
+ .appendValue(ChronoField.SECOND_OF_MINUTE, 2)
+ .appendLiteral(' ')
Review Comment:
Original code exist bug: don't consider 'T'.
BUG is so many, I will fix it by refactor all code about Parsing
Date/DateTime
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
