morrySnow commented on code in PR #24135:
URL: https://github.com/apache/doris/pull/24135#discussion_r1321317827
##########
fe/fe-core/src/main/java/org/apache/doris/statistics/AnalysisManager.java:
##########
@@ -175,27 +183,44 @@ public class AnalysisManager extends Daemon implements
Writable {
return null;
};
+ private final String progressDisplayTemplate = "%d Finished | %d Failed
| %d In Progress | %d Total";
- private final Function<TaskStatusWrapper, Void> systemJobStatusUpdater = w
-> {
+ protected final Function<TaskStatusWrapper, Void> systemJobStatusUpdater =
w -> {
AnalysisInfo info = w.info;
info.state = w.taskState;
+ info.message = w.message;
AnalysisInfo job = systemJobInfoMap.get(info.jobId);
if (job == null) {
return null;
}
- for (BaseAnalysisTask task :
analysisJobIdToTaskMap.get(info.jobId).values()) {
- if (!task.info.state.equals(AnalysisState.FINISHED)) {
- if (task.info.state.equals(AnalysisState.FAILED)) {
- systemJobInfoMap.remove(info.jobId);
- }
+ int failedCount = 0;
+ StringJoiner reason = new StringJoiner(",");
Review Comment:
```suggestion
StringJoiner reason = new StringJoiner(", ");
```
##########
fe/fe-common/src/main/java/org/apache/doris/common/Config.java:
##########
@@ -2165,4 +2165,10 @@ public class Config extends ConfigBase {
+ "The larger the value, the more uniform the distribution
of the hash algorithm, "
+ "but it will increase the memory overhead."})
public static int virtual_node_number = 2048;
+
+ @ConfField(description = {
+ "控制系统自动触发作业执行记录的持久化行数",
Review Comment:
In all descriptions, make it clear that these parameters control the
collection of statistics
##########
fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java:
##########
@@ -2586,6 +2586,7 @@ public List<ResultRow> executeInternalQuery() {
analyze(context.getSessionVariable().toThrift());
}
} catch (Exception e) {
+ LOG.warn("Failed to run internal SQL: {}",
originStmt.toString(), e);
Review Comment:
```suggestion
LOG.warn("Failed to run internal SQL: {}", originStmt, e);
```
##########
fe/fe-core/src/main/cup/sql_parser.cup:
##########
@@ -4216,13 +4216,17 @@ show_param ::=
RESULT = new ShowCreateMaterializedViewStmt(mvName, tableName);
:}
/* show analyze job */
- | KW_ANALYZE opt_table_name:tbl opt_wild_where
order_by_clause:orderByClause limit_clause:limitClause
Review Comment:
why remove order by and limit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
