yiguolei commented on code in PR #24029:
URL: https://github.com/apache/doris/pull/24029#discussion_r1322671413
##########
be/src/runtime/exec_env.h:
##########
@@ -305,4 +368,28 @@ ExecEnv::get_client_cache<TPaloBrokerServiceClient>() {
return _broker_client_cache;
}
+inline TabletSchemaCache* GetGlobalTabletSchemaCache() {
+ return ExecEnv::GetInstance()->get_tablet_schema_cache();
+}
+
+inline io::S3FileBufferPool* GetGlobalS3FileBufferPool() {
+ return ExecEnv::GetInstance()->get_s3_file_buffer_pool();
+}
+
+inline StorageEngine* GetGlobalStorageEngine() {
Review Comment:
I think we'd better unify the instance access method, there are 3 types:
1. ExecEnv::instance()->fragment_mgr
2. StoragePageCache()::instance()
3. GetGlobalStorageEngine()
I think not add method 3, it is very duplicated, the developer will not
know how to use them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
