amorynan commented on code in PR #24087:
URL: https://github.com/apache/doris/pull/24087#discussion_r1323843100
##########
be/src/vec/data_types/serde/data_type_nullable_serde.cpp:
##########
@@ -121,10 +120,11 @@ Status
DataTypeNullableSerDe::deserialize_one_cell_from_json(IColumn& column, Sl
auto& null_column = assert_cast<ColumnNullable&>(column);
// TODO(Amory) make null literal configurable
+ // only slice trim quote return true make sure slice is quoted and
converted_from_string make
+ // sure slice is from string parse , we can parse this "null" literal as
string "null" to
+ // nested column , otherwise we insert null to null column
if (!(options.converted_from_string && slice.trim_quote())) {
- //for map<string,string> type : {"abc","NULL"} , the NULL is string ,
instead of null values
- if (slice.size == 4 && slice[0] == 'N' && slice[1] == 'U' && slice[2]
== 'L' &&
- slice[3] == 'L') {
+ if (Slice::mem_equal("null", slice.data, 4)) {
Review Comment:
in json we do not support NULL just null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
