jackwener commented on code in PR #24600:
URL: https://github.com/apache/doris/pull/24600#discussion_r1329984294
##########
fe/fe-core/src/test/java/org/apache/doris/nereids/trees/expressions/SelectExceptTest.java:
##########
@@ -31,25 +31,26 @@
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;
-public class SelectExceptTest implements MemoPatternMatchSupported {
+class SelectExceptTest implements MemoPatternMatchSupported {
@Test
- public void testExcept() {
+ void testExcept() {
LogicalOlapScan olapScan = PlanConstructor.newLogicalOlapScan(0, "t1",
1);
LogicalProject<LogicalOlapScan> project = new LogicalProject<>(
ImmutableList.of(new UnboundStar(ImmutableList.of("db",
"t1"))),
ImmutableList.of(new UnboundSlot("db", "t1", "id")),
+ false,
olapScan);
PlanChecker.from(MemoTestUtils.createConnectContext())
.analyze(project)
.matches(
logicalProject(
logicalOlapScan()
- ).when(proj -> proj.getExcepts().isEmpty() &&
proj.getProjects().size() == 1)
+ ).when(proj -> proj.getExcepts().size() == 1 &&
proj.getProjects().size() == 1)
Review Comment:
Is there a bug in original code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
