yujun777 commented on code in PR #24639:
URL: https://github.com/apache/doris/pull/24639#discussion_r1330922281
##########
be/test/testutil/run_all_tests.cpp:
##########
@@ -47,10 +47,7 @@ int main(int argc, char** argv) {
doris::StoragePageCache::create_global_cache(1 << 30, 10, 0));
doris::ExecEnv::GetInstance()->set_segment_loader(new
doris::SegmentLoader(1000));
std::string conf = std::string(getenv("DORIS_HOME")) + "/conf/be.conf";
- if (!doris::config::init(conf.c_str(), false)) {
- fprintf(stderr, "error read config file. \n");
- return -1;
- }
+ doris::config::init(conf.c_str(), false);
Review Comment:
if config has big problem, exit is safe ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
