morrySnow commented on code in PR #23717:
URL: https://github.com/apache/doris/pull/23717#discussion_r1331348277
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/analyzer/UnboundRelation.java:
##########
@@ -44,6 +45,7 @@
*/
public class UnboundRelation extends LogicalRelation implements Unbound {
+ public final Optional<TableSample> tableSample;
Review Comment:
why public? make it private and add getter
##########
fe/fe-core/src/main/java/org/apache/doris/load/ExportJob.java:
##########
@@ -372,7 +372,7 @@ private LogicalPlan generateOneLogicalPlan(List<String>
qualifiedTableName, List
List<String> partitions, List<NamedExpression> selectLists) {
// UnboundRelation
LogicalPlan plan = new
UnboundRelation(StatementScopeIdGenerator.newRelationId(), qualifiedTableName,
- partitions, false, tabletIds, ImmutableList.of());
+ partitions, false, tabletIds, ImmutableList.of(), null);
Review Comment:
```suggestion
partitions, false, tabletIds, ImmutableList.of(),
Optional.empty());
```
?
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/physical/PhysicalOlapScan.java:
##########
@@ -45,6 +46,7 @@
*/
public class PhysicalOlapScan extends PhysicalCatalogRelation implements
OlapScan {
+ public final TableSample tableSample;
Review Comment:
optional private
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
