github-actions[bot] commented on code in PR #24638:
URL: https://github.com/apache/doris/pull/24638#discussion_r1332799216
##########
be/test/olap/rowid_conversion_test.cpp:
##########
@@ -329,26 +312,41 @@ class TestRowIdConversion : public
testing::TestWithParam<std::tuple<KeysType, b
new_overlap = OVERLAPPING;
}
}
- RowsetSharedPtr rowset = create_rowset(tablet_schema, new_overlap,
input_data[i]);
+ RowsetSharedPtr rowset = create_rowset(tablet_schema, new_overlap,
input_data[i], i);
input_rowsets.push_back(rowset);
}
+ if (has_delete_handler) {
+ // delete data with key < 1000
+ std::vector<TCondition> conditions;
Review Comment:
warning: variable 'conditions' is not initialized
[cppcoreguidelines-init-variables]
```suggestion
std::vector<TCondition> conditions = 0;
```
##########
be/test/olap/rowid_conversion_test.cpp:
##########
@@ -329,26 +312,41 @@ class TestRowIdConversion : public
testing::TestWithParam<std::tuple<KeysType, b
new_overlap = OVERLAPPING;
}
}
- RowsetSharedPtr rowset = create_rowset(tablet_schema, new_overlap,
input_data[i]);
+ RowsetSharedPtr rowset = create_rowset(tablet_schema, new_overlap,
input_data[i], i);
input_rowsets.push_back(rowset);
}
+ if (has_delete_handler) {
+ // delete data with key < 1000
+ std::vector<TCondition> conditions;
+ TCondition condition;
+ condition.column_name = tablet_schema->column(0).name();
+ condition.condition_op = "<";
+ condition.condition_values.clear();
+ condition.condition_values.push_back("1000");
+ conditions.push_back(condition);
+
+ DeletePredicatePB del_pred;
Review Comment:
warning: variable 'del_pred' is not initialized
[cppcoreguidelines-init-variables]
```suggestion
DeletePredicatePB del_pred = 0;
```
##########
be/test/olap/rowid_conversion_test.cpp:
##########
@@ -329,26 +312,41 @@ class TestRowIdConversion : public
testing::TestWithParam<std::tuple<KeysType, b
new_overlap = OVERLAPPING;
}
}
- RowsetSharedPtr rowset = create_rowset(tablet_schema, new_overlap,
input_data[i]);
+ RowsetSharedPtr rowset = create_rowset(tablet_schema, new_overlap,
input_data[i], i);
input_rowsets.push_back(rowset);
}
+ if (has_delete_handler) {
+ // delete data with key < 1000
+ std::vector<TCondition> conditions;
+ TCondition condition;
+ condition.column_name = tablet_schema->column(0).name();
+ condition.condition_op = "<";
+ condition.condition_values.clear();
+ condition.condition_values.push_back("1000");
+ conditions.push_back(condition);
+
+ DeletePredicatePB del_pred;
+ Status st =
Review Comment:
warning: variable 'st' is not initialized [cppcoreguidelines-init-variables]
```suggestion
Status st = 0 =
```
##########
be/test/olap/rowid_conversion_test.cpp:
##########
@@ -329,26 +312,41 @@ class TestRowIdConversion : public
testing::TestWithParam<std::tuple<KeysType, b
new_overlap = OVERLAPPING;
}
}
- RowsetSharedPtr rowset = create_rowset(tablet_schema, new_overlap,
input_data[i]);
+ RowsetSharedPtr rowset = create_rowset(tablet_schema, new_overlap,
input_data[i], i);
input_rowsets.push_back(rowset);
}
+ if (has_delete_handler) {
+ // delete data with key < 1000
+ std::vector<TCondition> conditions;
+ TCondition condition;
Review Comment:
warning: variable 'condition' is not initialized
[cppcoreguidelines-init-variables]
```suggestion
TCondition condition = 0;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
