yiguolei commented on code in PR #24724:
URL: https://github.com/apache/doris/pull/24724#discussion_r1333764889


##########
be/src/vec/exec/scan/new_olap_scanner.cpp:
##########
@@ -481,6 +481,12 @@ Status NewOlapScanner::_init_return_columns() {
         _return_columns.push_back(index);
         if (slot->is_nullable() && 
!_tablet_schema->column(index).is_nullable()) {
             _tablet_columns_convert_to_null_set.emplace(index);
+        } else if (!slot->is_nullable() && 
_tablet_schema->column(index).is_nullable()) {
+            throw doris::Exception(ErrorCode::INVALID_SCHEMA,
+                                   "slot(id: {}, name: {})'s nullable does not 
match "

Review Comment:
   could return error status and change the return value's attribute to [no 
discard]



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to