github-actions[bot] commented on code in PR #24129:
URL: https://github.com/apache/doris/pull/24129#discussion_r1336779847
##########
be/src/olap/rowset/segment_v2/bitshuffle_page_pre_decoder.h:
##########
@@ -38,8 +41,8 @@ struct BitShufflePagePreDecoder : public DataPagePreDecoder {
* @param size_of_tail including size of footer and null map
* @return Status
*/
- virtual Status decode(std::unique_ptr<DataPage>* page, Slice* page_slice,
- size_t size_of_tail) override {
+ virtual Status decode(std::unique_ptr<DataPage>* page, Slice* page_slice,
size_t size_of_tail,
Review Comment:
warning: 'virtual' is redundant since the function is already declared
'override' [modernize-use-override]
```suggestion
Status decode(std::unique_ptr<DataPage>* page, Slice* page_slice, size_t
size_of_tail,
```
##########
be/src/olap/rowset/segment_v2/bitshuffle_page.h:
##########
@@ -194,14 +194,11 @@ class BitshufflePageBuilder : public PageBuilder {
_data.push_back(0);
}
- // reserve enough place for compression
- _buffer.resize(
- BITSHUFFLE_PAGE_HEADER_SIZE +
- bitshuffle::compress_lz4_bound(num_elems_after_padding,
final_size_of_type, 0));
-
- int64_t bytes =
- bitshuffle::compress_lz4(_data.data(),
&_buffer[BITSHUFFLE_PAGE_HEADER_SIZE],
- num_elems_after_padding,
final_size_of_type, 0);
+ // reserve enough place for bitshuffle output
+ _buffer.resize(BITSHUFFLE_PAGE_HEADER_SIZE + _data.size());
+
+ int64_t bytes = bitshuffle::bitshuffle(_data.data(),
&_buffer[BITSHUFFLE_PAGE_HEADER_SIZE],
Review Comment:
warning: variable 'bytes' is not initialized
[cppcoreguidelines-init-variables]
```suggestion
int64_t bytes = 0 = bitshuffle::bitshuffle(_data.data(),
&_buffer[BITSHUFFLE_PAGE_HEADER_SIZE],
```
##########
be/src/olap/rowset/segment_v2/encoding_info.h:
##########
@@ -17,6 +17,7 @@
#pragma once
+#include <gen_cpp/segment_v2.pb.h>
Review Comment:
warning: 'gen_cpp/segment_v2.pb.h' file not found [clang-diagnostic-error]
```cpp
#include <gen_cpp/segment_v2.pb.h>
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
