github-actions[bot] commented on code in PR #24998:
URL: https://github.com/apache/doris/pull/24998#discussion_r1339601189
##########
be/src/vec/runtime/vparquet_transformer.cpp:
##########
@@ -476,7 +514,7 @@ Status VParquetTransformer::write(const Block& block) {
}
case TYPE_TINYINT:
case TYPE_SMALLINT: {
- parquet::RowGroupWriter* rgWriter = get_rg_writer();
+ parquet::RowGroupWriter* rgWriter = _get_rg_writer();
Review Comment:
warning: variable 'rgWriter' is not initialized
[cppcoreguidelines-init-variables]
```suggestion
parquet::RowGroupWriter* rgWriter = nullptr =
_get_rg_writer();
```
##########
be/src/vec/runtime/vparquet_transformer.cpp:
##########
@@ -304,14 +308,30 @@ Status VParquetTransformer::parse_properties() {
} else {
builder.enable_dictionary();
}
+ builder.max_row_group_length(4096);
_properties = builder.build();
+ _arrow_properties =
parquet::ArrowWriterProperties::Builder().store_schema()->build();
} catch (const parquet::ParquetException& e) {
return Status::InternalError("parquet writer parse properties error:
{}", e.what());
}
return Status::OK();
}
-Status VParquetTransformer::parse_schema() {
+Status VParquetTransformer::_parse_schema2() {
+ std::vector<std::shared_ptr<arrow::Field>> fields;
Review Comment:
warning: variable 'fields' is not initialized
[cppcoreguidelines-init-variables]
```suggestion
std::vector<std::shared_ptr<arrow::Field>> fields = 0;
```
##########
be/src/vec/runtime/vparquet_transformer.cpp:
##########
@@ -591,7 +629,7 @@ Status VParquetTransformer::write(const Block& block) {
break;
}
case TYPE_DATE: {
- parquet::RowGroupWriter* rgWriter = get_rg_writer();
+ parquet::RowGroupWriter* rgWriter = _get_rg_writer();
Review Comment:
warning: variable 'rgWriter' is not initialized
[cppcoreguidelines-init-variables]
```suggestion
parquet::RowGroupWriter* rgWriter = nullptr =
_get_rg_writer();
```
##########
be/src/vec/runtime/vparquet_transformer.cpp:
##########
@@ -745,7 +783,7 @@ Status VParquetTransformer::write(const Block& block) {
break;
}
case TYPE_DECIMALV2: {
- parquet::RowGroupWriter* rgWriter = get_rg_writer();
+ parquet::RowGroupWriter* rgWriter = _get_rg_writer();
Review Comment:
warning: variable 'rgWriter' is not initialized
[cppcoreguidelines-init-variables]
```suggestion
parquet::RowGroupWriter* rgWriter = nullptr =
_get_rg_writer();
```
##########
be/src/vec/data_types/serde/data_type_number_serde.cpp:
##########
@@ -81,15 +81,20 @@ void DataTypeNumberSerDe<T>::write_column_to_arrow(const
IColumn& column, const
end - start,
reinterpret_cast<const
uint8_t*>(arrow_null_map_data)),
column.get_name(), array_builder->type()->name());
- } else if constexpr (std::is_same_v<T, Int128> || std::is_same_v<T,
UInt128>) {
- ARROW_BUILDER_TYPE& builder =
assert_cast<ARROW_BUILDER_TYPE&>(*array_builder);
- size_t fixed_length = sizeof(typename ColumnType::value_type);
- const uint8_t* data_start =
- reinterpret_cast<const uint8_t*>(col_data.data()) + start *
fixed_length;
- checkArrowStatus(
- builder.AppendValues(data_start, end - start,
- reinterpret_cast<const
uint8_t*>(arrow_null_map_data)),
- column.get_name(), array_builder->type()->name());
+ } else if constexpr (std::is_same_v<T, Int128>) {
+ auto& string_builder =
assert_cast<arrow::StringBuilder&>(*array_builder);
+ for (size_t i = start; i < end; ++i) {
+ auto& data_value = col_data[i];
+ std::string value_str = fmt::format("{}", data_value);
+ if (null_map && (*null_map)[i]) {
Review Comment:
warning: variable 'value_str' is not initialized
[cppcoreguidelines-init-variables]
be/src/vec/data_types/serde/data_type_number_serde.cpp:89:
```diff
- ue_str = fmt::format("{}", data_value);
+ ue_str = 0 = fmt::format("{}", data_value);
```
##########
be/src/vec/runtime/vparquet_transformer.cpp:
##########
@@ -530,7 +568,7 @@ Status VParquetTransformer::write(const Block& block) {
break;
}
case TYPE_DATETIME: {
- parquet::RowGroupWriter* rgWriter = get_rg_writer();
+ parquet::RowGroupWriter* rgWriter = _get_rg_writer();
Review Comment:
warning: variable 'rgWriter' is not initialized
[cppcoreguidelines-init-variables]
```suggestion
parquet::RowGroupWriter* rgWriter = nullptr =
_get_rg_writer();
```
##########
be/src/vec/runtime/vparquet_transformer.cpp:
##########
@@ -431,7 +469,7 @@ Status VParquetTransformer::write(const Block& block) {
break;
}
case TYPE_LARGEINT: {
- parquet::RowGroupWriter* rgWriter = get_rg_writer();
+ parquet::RowGroupWriter* rgWriter = _get_rg_writer();
Review Comment:
warning: variable 'rgWriter' is not initialized
[cppcoreguidelines-init-variables]
```suggestion
parquet::RowGroupWriter* rgWriter = nullptr =
_get_rg_writer();
```
##########
be/src/vec/runtime/vparquet_transformer.cpp:
##########
@@ -294,7 +298,7 @@
VParquetTransformer::VParquetTransformer(doris::io::FileWriter* file_writer,
_outstream = std::shared_ptr<ParquetOutputStream>(new
ParquetOutputStream(file_writer));
}
-Status VParquetTransformer::parse_properties() {
+Status VParquetTransformer::_parse_properties() {
Review Comment:
warning: method '_parse_properties' can be made const
[readability-make-member-function-const]
```suggestion
Status VParquetTransformer::_parse_properties() const {
```
be/src/vec/runtime/vparquet_transformer.h:112:
```diff
- Status _parse_properties();
+ Status _parse_properties() const;
```
##########
be/src/vec/runtime/vparquet_transformer.cpp:
##########
@@ -643,7 +681,7 @@ Status VParquetTransformer::write(const Block& block) {
break;
}
case TYPE_DATEV2: {
- parquet::RowGroupWriter* rgWriter = get_rg_writer();
+ parquet::RowGroupWriter* rgWriter = _get_rg_writer();
Review Comment:
warning: variable 'rgWriter' is not initialized
[cppcoreguidelines-init-variables]
```suggestion
parquet::RowGroupWriter* rgWriter = nullptr =
_get_rg_writer();
```
##########
be/src/vec/runtime/vparquet_transformer.cpp:
##########
@@ -683,7 +721,7 @@ Status VParquetTransformer::write(const Block& block) {
break;
}
case TYPE_DATETIMEV2: {
- parquet::RowGroupWriter* rgWriter = get_rg_writer();
+ parquet::RowGroupWriter* rgWriter = _get_rg_writer();
Review Comment:
warning: variable 'rgWriter' is not initialized
[cppcoreguidelines-init-variables]
```suggestion
parquet::RowGroupWriter* rgWriter = nullptr =
_get_rg_writer();
```
##########
be/src/vec/runtime/vparquet_transformer.cpp:
##########
@@ -787,7 +825,7 @@ Status VParquetTransformer::write(const Block& block) {
break;
}
case TYPE_DECIMAL32: {
- parquet::RowGroupWriter* rgWriter = get_rg_writer();
+ parquet::RowGroupWriter* rgWriter = _get_rg_writer();
Review Comment:
warning: variable 'rgWriter' is not initialized
[cppcoreguidelines-init-variables]
```suggestion
parquet::RowGroupWriter* rgWriter = nullptr =
_get_rg_writer();
```
##########
be/src/vec/runtime/vparquet_transformer.cpp:
##########
@@ -822,7 +860,7 @@ Status VParquetTransformer::write(const Block& block) {
break;
}
case TYPE_DECIMAL64: {
- parquet::RowGroupWriter* rgWriter = get_rg_writer();
+ parquet::RowGroupWriter* rgWriter = _get_rg_writer();
Review Comment:
warning: variable 'rgWriter' is not initialized
[cppcoreguidelines-init-variables]
```suggestion
parquet::RowGroupWriter* rgWriter = nullptr =
_get_rg_writer();
```
##########
be/src/vec/runtime/vparquet_transformer.cpp:
##########
@@ -857,7 +895,7 @@ Status VParquetTransformer::write(const Block& block) {
break;
}
case TYPE_DECIMAL128I: {
- parquet::RowGroupWriter* rgWriter = get_rg_writer();
+ parquet::RowGroupWriter* rgWriter = _get_rg_writer();
Review Comment:
warning: variable 'rgWriter' is not initialized
[cppcoreguidelines-init-variables]
```suggestion
parquet::RowGroupWriter* rgWriter = nullptr =
_get_rg_writer();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
