morrySnow commented on code in PR #25089:
URL: https://github.com/apache/doris/pull/25089#discussion_r1349608267
##########
fe/fe-core/src/main/java/org/apache/doris/planner/PlanFragment.java:
##########
@@ -326,6 +326,8 @@ public String getExplainString(TExplainLevel explainLevel) {
}
str.append("\n");
str.append(" PARTITION: " +
dataPartition.getExplainString(explainLevel) + "\n");
+ str.append(" HAS_COLO_PLAN_NODE: " + hasColocatePlanNode + "\n");
Review Comment:
```suggestion
str.append(" HAS_COLOCATE_PLAN_NODE: " + hasColocatePlanNode +
"\n");
```
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/PhysicalPlanTranslator.java:
##########
@@ -1739,6 +1745,13 @@ public PlanFragment visitPhysicalSetOperation(
setPlanRoot(setOperationFragment, setOperationNode, setOperation);
}
+ // in pipeline engine, we use parallel scan by default, but it broke
the rule of data distribution
+ // we need turn of parallel scan to ensure to get correct result.
+ // TODO: nereids forbid all parallel scan under PhysicalSetOperation
temporary
+ if
(findOlapScanNodesByPassExchangeAndJoinNode(setOperationFragment.getPlanRoot()))
{
+ setOperationFragment.setHasColocatePlanNode(true);
+ }
Review Comment:
check set operation output physical properties, if it is any, do not set
this flag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
