yangzhg commented on a change in pull request #5033:
URL: https://github.com/apache/incubator-doris/pull/5033#discussion_r537256214
##########
File path: gensrc/thrift/DataSinks.thrift
##########
@@ -82,6 +83,12 @@ struct TMysqlTableSink {
6: required string table
}
+struct TOdbcTableSink {
+ 1: optional string connect_string
+ 2: optional string table
+ 3: optional bool is_transaction
Review comment:
maybe `use_transaction` is better
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
