morningman commented on code in PR #25280:
URL: https://github.com/apache/doris/pull/25280#discussion_r1357723996
##########
fe/fe-core/src/main/java/org/apache/doris/tablefunction/LocalTableValuedFunction.java:
##########
@@ -86,9 +86,9 @@ private void getFileListFromBackend() throws
AnalysisException {
Future<PGlobResponse> response = proxy.glob(address,
requestBuilder.build());
PGlobResponse globResponse = response.get(5, TimeUnit.SECONDS);
if (globResponse.getStatus().getStatusCode() != 0) {
- throw new AnalysisException(
- "error code: " +
globResponse.getStatus().getStatusCode()
- + ", error msg: " +
globResponse.getStatus().getErrorMsgsList());
+ LOG.warn("get file from backend failed. error code: {}, error
msg: {}",
Review Comment:
I think we should keep this exception.
For local tvf, it mains used for debug of POC, better expose every exception
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
